[FSSDK-12076] Pipeline update#397
Conversation
junaed-optimizely
requested review from
Copilot and
mikechu-optimizely
and removed request for
mikechu-optimizely
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the C# release workflow to support manual workflow dispatch and improves artifact management. The key improvement is fixing the tag variable resolution by properly passing it through step outputs instead of relying on environment variables, which resolves FSSDK-12076.
- Added manual workflow dispatch support with a required
taginput parameter for flexible release triggering - Fixed tag variable resolution by outputting it from the step instead of directly from environment variable
- Renamed artifact outputs to distinguish between framework targets (
unsigned-dlls-framework,unsigned-dlls-netstandard16,unsigned-dlls-netstandard20)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mikechu-optimizely
left a comment
mikechu-optimizely
left a comment
There was a problem hiding this comment.
Looks good. Thanks for fixing the tag propogation. One comment below for consideration.
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: unsigned-dlls | ||
| name: unsigned-dlls-framework |
There was a problem hiding this comment.
Note: I kept the unsigned binaries together to provide a single upload for signing. If you see this is better, I do not object.
There was a problem hiding this comment.
Due to recent changes in "upload artifact" action its not possible to upload same name artifact multiple times.
I was getting Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run and forced to do it this way.
The details of the breaking changes could be found here - https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
junaed-optimizely
deleted the
junaed/fssdk-11956-csharp-release-fixed
branch
2 participants
Summary
taginput, allowing users to specify a release tag when triggering the workflow manually. The workflow now resolves the tag from either the release event or the manual input and provides error messaging if no tag is available.unsigned-dlls-framework,unsigned-dlls-netstandard16, andunsigned-dlls-netstandard20, making it easier to track and download specific DLLs for each target. [1] [2] [3]Test plan
Issues